Fix tests for minitest 5.16 #45370
Merged
Fix tests for minitest 5.16 #45370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
force-pushed
the
fix-minitest-kwargs
branch
from
1b6ca2f
to
e4b2308
Compare
eileencodes
force-pushed
the
fix-minitest-kwargs
branch
from
e4b2308
to
2c80967
Compare
eileencodes
force-pushed
the
fix-minitest-kwargs
branch
from
2c80967
to
7a316ed
Compare
eileencodes
force-pushed
the
fix-minitest-kwargs
branch
from
a192b11
to
2a397c4
Compare
eileencodes
force-pushed
the
fix-minitest-kwargs
branch
2 times, most recently
from
272006b
to
1364b96
Compare
In minitest/minitest@6e06ac9 minitest changed such that it now accepts `kwargs` instead of requiring kwargs to be shoved into the args array. This is a good change but required some updates to our test code to get the new version of minitest passing. Changes are as follows: 1) Lock minitest to 5.15 for Ruby 2.7. We don't love this change but it's pretty difficult to get 2.7 and 3.0 to play nicely together with the new kwargs changes. Dropping 2.7 support isn't an option right now for Rails. This is safe because all of the code changes here are internal methods to Rails like assert_called_with. Applications shouldn't be consuming them as they are no-doc'd. 2) Update the `assert_called_with` method to take any kwargs but also the returns kwarg. 3) Update callers of `assert_called_with` to move the kwargs outside the args array. 4) Update the message from marshaled exceptions. In 5.16 the exception message is "result not reported" instead of "Wrapped undumpable exception". Co-authored-by: Matthew Draper <matthew@trebex.net>
eileencodes
force-pushed
the
fix-minitest-kwargs
branch
from
1364b96
to
9766eb4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In minitest/minitest@6e06ac9 minitest changed such that it now accepts
kwargsinstead of requiring kwargs to be shoved into the args array.This is a good change but required some updates to our test code to get
the new version of minitest passing.
Changes are as follows:
it's pretty difficult to get 2.7 and 3.0 to play nicely together with
the new kwargs changes. Dropping 2.7 support isn't an option right
now for Rails. This is safe because all of the code changes here are
internal methods to Rails like assert_called_with. Applications
shouldn't be consuming them as they are no-doc'd.
assert_called_withmethod to take any kwargs but alsothe returns kwarg.
assert_called_withto move the kwargs outside theargs array.
message is "result not reported" instead of "Wrapped undumpable
exception".
Co-authored-by: Matthew Draper matthew@trebex.net