Let sqlite strict config read from database.yml or config

[ghiculescu]

Per this discussion: #45346 (comment)

The adapter should read from database.yml, if a value is provided for strict. If no value is provided then it should fall back to config.active_record.strict_strings_by_default.

cc @fatkodima

[ghiculescu]

The flakey tests seem unrelated, they aren't on the SQlite adapter.

[yahonda]

Restarted flaky two jobs.

What do you think about removing strict: below?

rails/activerecord/test/config.example.yml

Lines 93 to 101 in 507cc6f

	sqlite3:
	arunit:
	database: <%= FIXTURES_ROOT %>/fixture_database.sqlite3
	timeout: 5000
	strict: true
	arunit2:
	database: <%= FIXTURES_ROOT %>/fixture_database_2.sqlite3
	timeout: 5000
	strict: true

[ghiculescu]

I think it’s fine to remove. @fatkodima agree?

[fatkodima]

It is used, as described here #45346 (comment). sqlite3_adapter_strict_strings_by_default is false, so we need to somehow test active record that it is working when this mode is enabled. For example, code for check constraints was previously broken in this mode.

For example, you can revert locally the changes in this file - https://github.com/rails/rails/pull/45346/files#diff-a583ecafedcde366950515cba5e7a808c51d85688d3b1de18fafe69f92838899 and set strict: true in a database.yml in a sample app and observe an error.

[ghiculescu]

Ohh right, now I follow. @yahonda FYI, we should keep the config as is.

[byroot]

Looks good to me. @ghiculescu is this missing anything?

[fatkodima]

@byroot This is good to merge.