Fix minor errata on debugging section [ci-skip] #45391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -436,13 +436,12 @@ It's also possible to use these options together: `backtrace [num] /pattern/`. | |||
|
|
|||
| #### The outline command | |||
|
|
|||
| This command is similar to `pry` and `irb`'s `ls` command. It will show you what's accessible from you current scope, including: | |||
| This command is similar to `pry` and `irb`'s `ls` command. It will show you what's accessible from the current scope which among others, include: | |||
There was a problem hiding this comment.
Hmm, "including:" still reads more naturally to me.
Suggested change
| This command is similar to `pry` and `irb`'s `ls` command. It will show you what's accessible from the current scope which among others, include: | |
| This command is similar to `pry` and `irb`'s `ls` command. It will show you what's accessible from the current scope, including: |
| @@ -491,7 +490,7 @@ And to remove them, you can use: | |||
|
|
|||
| #### The break command | |||
|
|
|||
| **Set a breakpoint with specified line number - e.g. `b 28`** | |||
| **Set a breakpoint with the specified line number - e.g. `b 28`** | |||
There was a problem hiding this comment.
Suggested change
| **Set a breakpoint with the specified line number - e.g. `b 28`** | |
| **Set a breakpoint on a specified line number - e.g. `b 28`** |
| @@ -532,7 +531,7 @@ And to remove them, you can use: | |||
| Stop by #0 BP - Line /Users/st0012/projects/rails-guide-example/app/controllers/posts_controller.rb:28 (line) | |||
| ``` | |||
|
|
|||
| **Set a breakpoint on a given method call - e.g. `b @post.save`** | |||
| **Set a breakpoint on the given method call - e.g. `b @post.save`** | |||
There was a problem hiding this comment.
Here, I think "a given method call" reads more naturally than "the given method call", because "given method call" has not yet been introduced. If there were another sentence following this one, then it may be more natural to refer to "the given method call" in that sentence, e.g. "If the given method call contains invalid syntax...".
Suggested change
| **Set a breakpoint on the given method call - e.g. `b @post.save`** | |
| **Set a breakpoint on a given method call - e.g. `b @post.save`** |
|
All good @jonathanhefner |
jonathanhefner
approved these changes
Jun 18, 2022
|
Thank you, @siaw23! 😄 (Backported to |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 25, 2022
Fix minor errata on debugging section [ci-skip] (cherry picked from commit 9a7d442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Other Information