Fix CollectionProxy#load_async #45440
Merged
+63
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: rails#45408 Since `CollectionProxy` inherits from `Relation`, `load_async` would schedule the query and store in it an instance variable but would never use it. Ideally we should make the `Association` classes async aware so that that you can indeed schedule an association to be loaded, but that's quite a big refactoring, and would be hard to backport to 7-0-stable. So this is a more focused fix. We delegate `load_async` to `scope` which means we return an async `Relation` that can later be used. However the association isn't marked as loaded, so if you use the association later, you'll trigger a second query anyway. I'll try to address this in a followup that won't be backported.
casperisfine
force-pushed
the
association-proxy-load-async
branch
from
be7a6d6
to
4b121f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #45408
Since
CollectionProxyinherits fromRelation,load_asyncwould schedule the query and store in it an instance variable but would never use it.Ideally we should make the
Associationclasses async aware so that that you can indeed schedule an association to be loaded, but that's quite a big refactoring, and would be hard to backport to 7-0-stable.So this is a more focused fix. We delegate
load_asynctoscopewhich means we return an asyncRelationthat can later be used.However the association isn't marked as loaded, so if you use the association later, you'll trigger a second query anyway.
I'll try to address this in a followup that won't be backported.
I'll add a CHANGELOG entry in the backport commit.