Feature/updates guide generation - EPUB #45539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
requested changes
Jul 11, 2022
There was a problem hiding this comment.
Thanks for working on this!
I know the code for generation was taken from the previous kindle code, but I think there's some room to clean it up as part of this PR so I've left a few comments around style etc.
After making these changes the PR will need to be squashed into 1 commit with a descriptive commit message about what is changing and why. We'll need a changelog entry too noting that mobi is no longer generated and instead we just generate an epub for kindle.
|
Thank you, @eileencodes, for reviewing this. |
|
@eileencodes I have completed doing everything you mentioned. |
eileencodes
reviewed
Aug 4, 2022
Removes kindlerb logic Adds template for epub generator Renames the kindle dir to /epub Adds epub module to generator and replaces kindle Fixes mimetype Creates basic epub book Deletes old kindle module Adds zip package Updates rubyzip gem name Removes now unused gepub gem Adds the required container file for epubs Fixes media type Adds new epub generation logic Removes all buttons from output html Refactors and generates valid epub files Removes frontmatter logic used for kindlegen Filters out epub files in zip Updates link to kindle doc on sidebar Fixes rubocop issues Adds deprecation warning for the old kindle task Refactors and cleans up epub module Cleans up epub code Cleans up private internal method code style Removes unnecessary imagemagick check
geongeorge
force-pushed
the
feature/updates-guide-generation-epub
branch
from
c21716c
to
56e96d9
Compare
|
Thanks @geongeorge for taking on this task and congrats on your first PR to Rails 🎉 |
This was referenced Aug 12, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the existing Kindle version of the guide from .mobi to .epub because Amazon is discontinuing support for the .mobi format.
See issue: #45499
Tested the EPUB on Calibre, Apple books, Kindle Paperwhite (7th Gen), Kindle (10th Gen), ReadEra on android
Additional benefits
Other Information
ruby_on_rails_guides_fbbdd2b.epub.zip