Improve performance by removing respond_to? from runtime code #45578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Jul 12, 2022
natematykiewicz
force-pushed
the
yaml_safe_load_performance
branch
from
863fd1d
to
326f44a
Compare
respond_to? is inherently slow, and the YAML class won't change whether it does or does not respond to unsafe_load, so just check it once during file load, and define methods accordingly.
natematykiewicz
force-pushed
the
yaml_safe_load_performance
branch
from
326f44a
to
f8f5c43
Compare
byroot
approved these changes
Jul 12, 2022
|
Is this worth a x.x.x.2 release? I'm honestly unsure how big of a performance difference this is. It's sort of a regression fix for the security release that went out today. But maybe it's not enough of a deal to warrant a release. |
No it's not. The performance difference isn't that big to really matter that much. I'll merge tomorrow, but probably won't bother backporting. |
|
Makes sense. Thanks! |
tenderlove
approved these changes
Jul 12, 2022
rafaelfranca
added a commit
that referenced
this pull request
Jul 12, 2022
…ance Improve performance by removing respond_to? from runtime code
rafaelfranca
added a commit
that referenced
this pull request
Jul 12, 2022
…ance Improve performance by removing respond_to? from runtime code
eileencodes
pushed a commit
that referenced
this pull request
Jul 15, 2022
…ance Improve performance by removing respond_to? from runtime code
eileencodes
pushed a commit
that referenced
this pull request
Jul 15, 2022
…ance Improve performance by removing respond_to? from runtime code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
respond_to? is inherently slow, and the YAML class won't change whether
it does or does not respond to unsafe_load, so just check it once
during file load, and define methods accordingly.
cc @byroot