Add endless range example to the Active Record Querying guide [ci-skip] #45617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajporterfield
changed the title
Comment on lines
662
to
670
| ```ruby | ||
| Book.where(created_at: (Time.now.midnight - 1.year)..) | ||
| ``` | ||
|
|
||
| This would generate SQL like: | ||
|
|
||
| ```sql | ||
| SELECT * FROM books WHERE books.created_at >= '2021-07-18 00:00:00' | ||
| ``` |
There was a problem hiding this comment.
For better comparison / contrast, what do you think about sticking more closely to the example just above this?
Suggested change
| ```ruby | |
| Book.where(created_at: (Time.now.midnight - 1.year)..) | |
| ``` | |
| This would generate SQL like: | |
| ```sql | |
| SELECT * FROM books WHERE books.created_at >= '2021-07-18 00:00:00' | |
| ``` | |
| ```ruby | |
| Book.where(created_at: (Time.now.midnight - 1.day)..) | |
| ``` | |
| This would generate SQL like: | |
| ```sql | |
| SELECT * FROM books WHERE books.created_at >= '2008-12-21 00:00:00' | |
| ``` |
There was a problem hiding this comment.
Great suggestion @jonathanhefner. I've made that change. Thanks for the review.
jonathanhefner
changed the title
ajporterfield
force-pushed
the
add-beginless-range-example-to-ar-querying-guide
branch
from
d51a008
to
504887c
Compare
|
Thank you, @ajporterfield! 😄 (Backported to |
jonathanhefner
added a commit
that referenced
this pull request
Jul 24, 2022
…ple-to-ar-querying-guide Add endless range example to the Active Record Querying guide [ci-skip] (cherry picked from commit bc0f07b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Beginless/endless ranges are something I recently discovered. I find them very handy and wish I would have known about them sooner. I think they're definitely worth mentioning in this guide.