Extract #build_add_column_definition
#45643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
changed the title
#build_create_add_column_definition#build_add_column_definition
adrianna-chang-shopify
force-pushed
the
ac-extract-build-add-col-definition
branch
from
8ac9aa9
to
6edf0a2
Compare
eileencodes
reviewed
Jul 27, 2022
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
Outdated
Show resolved
Hide resolved
adrianna-chang-shopify
force-pushed
the
ac-extract-build-add-col-definition
branch
2 times, most recently
from
9b082fe
to
9d13ba4
Compare
Exposes AlterTable schema definition for adding new columns through new API, and stores ddl on the schema definition. Refactors existing #add_column method to use this as an intermediate method to build the create add_column definition.
adrianna-chang-shopify
force-pushed
the
ac-extract-build-add-col-definition
branch
from
9d13ba4
to
e91b642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #45625 for more context on exposing schema definition APIs.
Summary
This PR exposes the
AlterTableschema definition that is produced when adding columns to a table. It does so through a new API,#build_add_column_definition, and stores ddl on the schema definition. It refactors the existing#add_columnmethod to use this as an intermediate method to build the add_column definition.