Remove duplicate 'updating' option from generator #45647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:update has been defined since a7adec9, and both options serve the same purpose
| @@ -31,7 +31,6 @@ def generator_options | |||
| options[:skip_test] = !defined?(Rails::TestUnitRailtie) | |||
| options[:skip_asset_pipeline] = !defined?(Sprockets::Railtie) && !defined?(Propshaft::Railtie) | |||
| options[:skip_bootsnap] = !defined?(Bootsnap) | |||
| options[:updating] = true | |||
There was a problem hiding this comment.
I kind of like options[:updating] better than options[:update]. Is there a reason to prefer one over the other? It looks there are (a small few) more occurrences of options[:updating]:
$ git grep 'options\[:updating\]' | wc -l
6
$ git grep 'options\[:update\]' | wc -l
2There was a problem hiding this comment.
I initially picked :update because its older, but I also think it aligns with the naming of other options (since these are technically rails new CLI options). :pretend, :force, :quiet etc. make me think :update is a better fit vs :pretending, :forcing, :quietly where I think :updating would make more sense.
|
Thank you, @skipkayhil! ✔️ ✔️ ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
:updatehas been defined since a7adec9, and both options serve the samepurpose