Make EncryptedFile more memoization-friendly
#45657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `EncryptedFile` would internally memoize when a key file was non-existent. This meant that a key file generated after checking `encrypted_file.key.nil?` would not be recognized, unless a new `EncryptedFile` instance was used. (Though setting the key in a designated environment variable instead would entirely bypass this memoization.) This commit changes `EncryptedFile` to only memoize when the key file has been read. Consequently, this commit memoizes the `EncryptedFile` (or, specifically, `EncryptedConfiguration`) instance used by `CredentialsCommand`. This commit also adds more test coverage around key file generation for `CredentialsCommand`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
EncryptedFilewould internally memoize when a key file was non-existent. This meant that a key file generated after checkingencrypted_file.key.nil?would not be recognized, unless a newEncryptedFileinstance was used. (Though setting the key in a designated environment variable instead would entirely bypass this memoization.)This commit changes
EncryptedFileto only memoize when the key file has been read. Consequently, this commit memoizes theEncryptedFile(or, specifically,EncryptedConfiguration) instance used byCredentialsCommand.This commit also adds more test coverage around key file generation for
CredentialsCommand.