Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test ensuring no subqueries for whole table batching #45671

Merged
merged 1 commit into from Jul 27, 2022

Conversation

fatkodima
Copy link
Member

Follow up to #45414.
As discussed in #45414 (comment).

cc @byroot

@simi
Copy link
Contributor

simi commented Jul 27, 2022

Thanks for the followup @fatkodima. I did quick check locally and commenting out except part in batching logic makes this test failing. 💪

@byroot byroot merged commit e1a2c9e into rails:main Jul 27, 2022
@byroot
Copy link
Member

byroot commented Jul 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants