Extract #build_change_column_definition
#45684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Define APIs on the MySQL and PostgreSQL connection adapters for building
ChangeColumnDefinition objects. These provide information on what a
column change would look like, when called with the same arguments as
would be passed to #change_column.
See #45625 for more context on exposing schema definition APIs.
Other Information
I've left out a definition for SQLite3, because it performs
#change_column
by replacing the entire table definition:rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
Lines 311 to 318 in 74a9929
We could define
#build_change_column_definition
to essentially wrap the new column definition, but this wouldn't actually be used by#change_column
, and we wouldn't be able to set theddl
, so I opted to just ignore it.