Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unless statement in one of the view files in getting started guide #45693

Closed
bhaskarshankarling opened this issue Jul 29, 2022 · 0 comments · Fixed by #45692
Closed

Comments

@bhaskarshankarling
Copy link

bhaskarshankarling commented Jul 29, 2022

Steps to reproduce

Compare the content of app/views/comments/_comment.html.erb between rails-getting-started-guide#using-concerns and rails-getting-started-guide#deleting-comments, a unless statement is missing in rails-getting-started-guide#deleting-comments. See the images attached below

Contents of _comment.html.erb from Using Concerns section

Screenshot 2022-07-29 at 4 51 01 PM

Contents of _comment.html.erb from Deleting Comments section

Screenshot 2022-07-29 at 4 51 39 PM

Expected behavior

app/views/comments/_comment.html.erb in both rails-getting-started-guide#using-concerns and rails-getting-started-guide#deleting-comments should have the below unless statement

<% unless comment.archived? %>
...
...
<% end %>

Actual behavior

unless statement is missing from app/views/comments/_comment.html.erb in rails-getting-started-guide#deleting-comments

System configuration

Rails version: v7.0.3.1

Ruby version: NA


I have raised a PR #45692 to fix this issue in the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant