Replace regexp matching with a simple string manipulation.

[semaperepelitsa]

Using regexp looks like overkill here and is also 2x slower.

             user     system      total        real
string   0.020000   0.000000   0.020000 (  0.016256)
regexp   0.030000   0.000000   0.030000 (  0.035360)

require "benchmark"

names = ("a".."z").map { |c| c + "a" * rand(5..10) + "=" * rand(0..1) }.map(&:to_sym)
puts names

n = 1000
Benchmark.bmbm do |x|
  x.report "string" do
    n.times do
      names.each do |name|
        string_name = name.to_s
        string_name.chomp!('=')
        string_name
      end
    end
  end

  x.report "regexp" do
    n.times do
      names.each do |name|
        name.to_s =~ /(.*)=$/
        $1
      end
    end
  end
end

[jonleighton]

@semaperepelitsa FWIW I am not very convinced by this benchmark. N is too small to draw any meaningful conclusions. But I don't have a problem with this patch being merged, just a heads up that you should benchmark over more iterations in the future :)

[semaperepelitsa]

I've benchmarked for 10_000 and 100_000 as well, the numbers have grown linearly 10x and 100x respectively. Picked up the most realistic yet big enough number :-)