Refactor ExtendedDeterministicQueries to not mutate the arguments #45722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: rails#41659 Mutating the attributes hash requires to workaround the mutation in `find_or_create_by` etc. One extra Hash dup is not big deal.
|
Merging now since this is blocking #45720, but if there are any concerns please review the PR anyway and I'll address any concerns with this change. |
|
I know 7.1 is just around the corner, but any chance you could backport this to Mutating the arguments is a bug IMO. Here is a test you could add here: test "query params are not mutated" do
b = EncryptedBook.create!(name: "Dune")
props = { name: "Dune", id: b.id }
p2 = props.dup
assert_equal "Dune", EncryptedBook.find_by(props).name
assert_equal p2, props
end |
|
If you make a backport PR I'll merge it. |
ghiculescu
added a commit
to ghiculescu/rails
that referenced
this pull request
Sep 12, 2023
Adds a test for rails#45722
This was referenced Sep 12, 2023
ghiculescu
pushed a commit
to ghiculescu/rails
that referenced
this pull request
Sep 12, 2023
…-mutation Refactor ExtendedDeterministicQueries to not mutate the arguments Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
|
Thanks. Made one to backport, and one to add a regression test to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #41659
Mutating the attributes hash requires to workaround the mutation in
find_or_create_byetc.One extra Hash dup is not big deal.
As discussed in #45720
cc @matthewd @jorgemanrubia