change AR default_timezone to :utc since it's the default for AR::Railtie #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
Jan 21, 2012
change AR default_timezone to :utc since it's the default for AR::Railtie
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jul 15, 2016
Since Rails 4 this value changed from :local to :utc rails/rails#4573 There are 7 specs which explicitly need to set `ActiveRecord::Base.default_timezone = :local`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an already known inconsistency reported here https://rails.lighthouseapp.com/projects/8994/tickets/5679-activerecordbasedefault_timezone
Since AR 3.0,
AR::Base.default_timezoneis set to:utcin Railtie https://github.com/rails/rails/blob/c05f3b0e4f/activerecord/lib/active_record/railtie.rb#L48then overridden to
:localat Base or Corehttps://github.com/rails/rails/blob/c05f3b0e4f/activerecord/lib/active_record/core.rb#L51
Because of this,
AR::Base.default_timezonevalue defers for a Rails appand a Ruby script that doesn't load
AR::RailtieThe next major version up must be the best timing for fixing this inconsistency, so I propose this patch again for 4.0.