Fix flaky tests for RedisCacheStore #45732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
commented
Aug 2, 2022
| @@ -131,9 +131,9 @@ def test_read_multi_with_expires | |||
| end | |||
|
|
|||
| def test_read_multi_with_empty_keys_and_a_logger_and_no_namespace | |||
| @cache.options[:namespace] = nil | |||
There was a problem hiding this comment.
This was the main offending line - we reset the namespace, and @cache.clear in teardown just flushed the db and we get nils in our tests.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails uses several processes to run tests for
RedisCacheStoreviabin/test test/cache/store/redis_cache_store_test.rb.When they run serially (with
PARALLEL_WORKERS=1) - everything works as expected, but in parallel - I almost always saw failing tests.With this changes I ran tests 100 times and saw no errors.
cc @byroot