Define #build_change_column_definition for MySQL and PG #45751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define APIs on the MySQL and PostgreSQL connection adapters for building ChangeColumnDefaultDefinition objects. These provide information on what a column default change would look like, when called with the same arguments as would be passed to #change_column_default.
adrianna-chang-shopify
force-pushed
the
ac-build-change-column-default-definition
branch
from
bd87098
to
7455336
Compare
|
That build was really flaky but none of the failures were in active record so I merged. Thanks @adrianna-chang-shopify! |
adrianna-chang-shopify
deleted the
ac-build-change-column-default-definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Define APIs on the MySQL and PostgreSQL connection adapters for building
ChangeColumnDefaultDefinition objects. These provide information on what a
column default change would look like, when called with the same arguments as
would be passed to #change_column_default.
Other Information
As with
#change_column, we ignore SQLite because it recreates the table from scratch when performingchange_columnoperations.