Nested attribute docs improvements #45829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The red build is unrelated (this is docs only). |
skipkayhil
reviewed
Aug 15, 2022
ghiculescu
force-pushed
the
nested-attribute-docs-improvements
branch
from
9fc279f
to
9062aff
Compare
2 small improvemennts to the docs for `ActiveRecord::NestedAttributes`. - Include a link to `ActionView::Helpers::FormHelper::fields_for`, since you would typically use these tools in tandem I think it makes sense to point you to it. - Show an example of how to write an integration test when using `ActionView::Helpers::FormHelper::fields_for`. You could argue that this example should also go in Action View, but I think it makes more sense here as the "parent" doc for the Nested Attributes feature.
ghiculescu
force-pushed
the
nested-attribute-docs-improvements
branch
from
9062aff
to
10a8320
Compare
skipkayhil
approved these changes
Aug 15, 2022
p8
reviewed
Aug 16, 2022
Comment on lines
+291
to
+292
| # If you are using ActionView::Helpers::FormHelper#fields_for, your integration | ||
| # tests should replicate the HTML structure it provides. For example; |
There was a problem hiding this comment.
Doesn't this always apply when using accepts_nested_attributes_for?
Even when you're not using fields_for?
There was a problem hiding this comment.
I'm also wondering if describing the integration with ActionView and ActionController is more suited for the guides. Maybe we should instead link to https://guides.rubyonrails.org/form_helpers.html#nested-forms ?
There was a problem hiding this comment.
@p8 i agree with these suggestions but I won’t get to them for a little while. If you like, I’d love for you to take over the PR.
p8
reviewed
Aug 16, 2022
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 small improvemennts to the docs for
ActiveRecord::NestedAttributes.ActionView::Helpers::FormHelper::fields_for, since you would typically use these tools in tandem I think it makes sense to point you to it.ActionView::Helpers::FormHelper::fields_for. You could argue that this example should also go in Action View, but I think it makes more sense here as the "parent" doc for the Nested Attributes feature.