Replace MutexHook by MonitorHook to allow reentrancy #45857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: rails#43550 If `executor_around_test_case` is enabled, all hooks must be reentrant. However `allow_concurrency = false` register a `MutexHook` that isn't reentrant. So this commit replace it by a `Monitor` which does allow reentrancy.
casperisfine
force-pushed
the
monitor-hook
branch
from
8cf8e1e
to
bc4c3ef
Compare
byroot
added a commit
that referenced
this pull request
Aug 19, 2022
Replace MutexHook by MonitorHook to allow reentrancy
|
Nice! TIL about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #45852
Ref: #43550
If
executor_around_test_caseis enabled, all hooks must be reentrant. Howeverallow_concurrency = falseregister aMutexHookthat isn't reentrant.So this commit replace it by a
Monitorwhich does allow reentrancy.cc @JiaboHou, @skipkayhil