Extend dangerous attribute methods with dangerous methods from Object #45883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45879 (see there for more details).
I do not like this approach, because this list can possibly be incomplete for some concrete apps. For example, some gem can monkey patch
Object
with some popular name and with this approach this name now will be dangerous.Another reason, this approach (besides properties) also makes methods with arguments as dangerous. But this is not needed, because when the user will pass arguments, then this will blow up, showing that he is doing something wrong.
So I propose to add a small explicit list of the most likely used dangerous methods. I did not add
__send__
/send
/method_missing
/etc (as mentioned in #45879 (comment)), because they require arguments and this will already blow up and won't go unnoticed.cc @byroot