Revert "Replace method_source gem with stdlib equivalent"
#45972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7690290, the filter was not finding the end of the methods defined using the `test do` syntax. This would cause more than 1 test to be selected depending on the line number passed as argument. The previous test wasn't failing because the two tests asked to run where one after the other and the filter, even broken would only run those two tests. By changing the test definition order we trigger the bug introduced by that commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45904
on_defdoesn't work with the declarative test definition since it will not trigger for those methods. We might make this work by hooking to method calls nodes usingRipperbut since this broke the filtering I'm reverting. I'm ok with a new PR that doesn't break it. I'll also make sure this doesn't regress by making sure a test fails when we forget to filter the declarative definition.