Use explicit deprecator in AS::Deprecation tests
#46000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes many deprecation tests to use an explicit deprecator, as part of an initiative to move away from the top-level `ActiveSupport::Deprecation` API, based on the discussion in rails#44772.
jonathanhefner
force-pushed
the
deprecation-tests-use-explicit-deprecator
branch
from
d4ae028
to
2b7c03e
Compare
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Sep 13, 2022
Follow-up to rails#46000. This changes more deprecation tests to use an explicit deprecator, as part of an initiative to move away from the top-level `ActiveSupport::Deprecation` API, based on the discussion in rails#44772.
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Sep 22, 2022
This changes `MethodWrappersTest` and `ProxyWrappersTest` tests to use an explicit deprecator, similar to what was done for `DeprecationTest` in rails#46000 and its follow-ups.
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Oct 24, 2022
This commits adds a deprecator-only overload for `assert_deprecated`. For example, `assert_deprecated(/./, deprecator)` can now be written as `assert_deprecated(deprecator)`. This is part of an initiative to move away from the top-level `ActiveSupport::Deprecation` API, towards per-library deprecator instances. See also rails#46000 and its follow-ups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes many deprecation tests to use an explicit deprecator, as part of an initiative to move away from the top-level
ActiveSupport::DeprecationAPI, based on the discussion in #44772.The diff is best viewed with the "ignore whitespace" option.