Allow empty callstack in AS::Deprecation#warn
#46001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an "undefined method 'path' for nil:NilClass" error in `Deprecation::Reporting#extract_callstack` when the callstack is empty, either because it was specified as such or because the `warn` call was not sufficiently deep in a call tree (e.g. at the top level of a new thread).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an "undefined method 'path' for nil:NilClass" error in
Deprecation::Reporting#extract_callstackwhen the callstack is empty, either because it was specified as such or because thewarncall was not sufficiently deep in a call tree (e.g. at the top level of a new thread).