CookieJar#deleted? predicate method #4613
Conversation
Necessary in controller tests to determine if the CookieJar will delete the given cookie.
| @@ -180,8 +180,7 @@ def recycle! | |||
| @env['action_dispatch.request.query_parameters'] = {} | |||
| @set_cookies ||= {} | |||
| @set_cookies.update(Hash[cookie_jar.instance_variable_get("@set_cookies").map{ |k,o| [k,o[:value]] }]) | |||
| deleted_cookies = cookie_jar.instance_variable_get("@delete_cookies") | |||
| @set_cookies.reject!{ |k,v| deleted_cookies.include?(k) } | |||
| @set_cookies.reject!{ |k,v| cookie_jar.deleted?(k) } | |||
There was a problem hiding this comment.
These are not exactly equivalent. The first one would delete any cookie regardless of the path or the domain, while the second one won't.
There was a problem hiding this comment.
Good point. I'll eliminate that commit, leaving just the addition of the #deleted? method.
|
Removed change to |
|
Another option is to have deleted?(key) check if they key was deleted regardless of the options or add another method for that. Better than the instance variable get check. |
|
I was initially reluctant to have |
CookieJar#deleted? predicate method
ActionDispatch::Cookies::CookieJarneeds a way to query for deleted cookies.Here's an example use case from a controller test:
Cheers!
Paul