Execute the before_committed! callbacks on the most recent copy of the record #46525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
rm-fix-touch
branch
from
ece4443
to
2cb1ae1
Compare
The value of `touch_method` will always be `:touch_later`, so we can remove all the complexity of passing it around.
…the record Same as #36190 but for `before_committed!` callbacks. Before only the early copy of the same record (different object ids, but pointing to the same record in the database) was used to execute the callback, but it didn't have the touch_later information. Fixes #26726. Co-authored-by: Wolfram Nikolas Müller <muellerwolfram@gmail.com>
rafaelfranca
force-pushed
the
rm-fix-touch
branch
from
2cb1ae1
to
6175f73
Compare
adrianna-chang-shopify
added a commit
to Shopify/rails
that referenced
this pull request
Dec 15, 2022
4 tasks
adrianna-chang-shopify
added a commit
to adrianna-chang-shopify/rails
that referenced
this pull request
Dec 15, 2022
As of rails#46525, the behaviour around before_committed! callbacks has changed: callbacks are run on every enrolled record in a transaction, even multiple copies of the same record. This is a significant change that apps should be able to opt into in order to avoid unexpected issues.
|
By switching from |
|
That is a bug. Can you open an issue with a way to reproduce? It is very likely this commit can be reverted since it isn't strictly necessary. It was jus a refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #36190 but for
before_committed!callbacks.Before only the early copy of the same record (different object ids, but
pointing to the same record in the database) was used to execute the
callback, but it didn't have the touch_later information.
Fixes #26726.