Modify video_tag a bit and make audio_tag able to accept multiple sources #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests please. |
|
I hope I've done it the right way, since this is my first real pull request :) |
|
Do the tests pass after your changes? If so, you did it the right way. :) |
|
Yes, they did. |
josevalim
added a commit
that referenced
this pull request
Jan 25, 2012
Modify video_tag a bit and make audio_tag able to accept multiple sources
|
I am unsure if this has changed since this commit however I tried: audio_tag(["audio.mp3", "audio.ogg"], :controls => true) Is this not the correct syntax? The output I received was: audio controls="controls" src="/audios/["audio.mp3", "audio.ogg"]" |
|
This has been merged to master and I'm unsure if it got backported to 3-2, which means it is probably not available in a stable release yet. |
|
I'm also having the same issue as andrewdavidcostello. Is there a work around? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To
video_tagI just added that, when it accepts multiple sources,path_to_videois applied to each of them. And inaudio_tagI just copied the logic fromvideo_tag.