Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text to include comma and add articles before nouns #46623

Merged
merged 1 commit into from Dec 1, 2022
Merged

Update text to include comma and add articles before nouns #46623

merged 1 commit into from Dec 1, 2022

Conversation

cjilbert504
Copy link
Contributor

@cjilbert504 cjilbert504 commented Dec 1, 2022

Motivation / Background

This Pull Request has been created because the current documentation lacks certain grammar resulting in a few odd-to-read places where articles were missing in front of nouns.

Detail

This Pull Request changes a few lines in the documentation to provide improved legibility for the reader by adding punctuation and noun modifications.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.
  • CI is passing.

@rails-bot rails-bot bot added the docs label Dec 1, 2022
@jonathanhefner jonathanhefner merged commit d79b7d5 into rails:main Dec 1, 2022
@jonathanhefner
Copy link
Member

jonathanhefner commented Dec 1, 2022

Thank you, @cjilbert504! 👋

Backported to 7-0-stable.

@cjilbert504 cjilbert504 deleted the migration-comment-option-grammar branch December 1, 2022 16:06
@cjilbert504
Copy link
Contributor Author

Thank you, @jonathanhefner!!! 😀

jonathanhefner added a commit that referenced this pull request Jan 24, 2023
…rammar

Update text to include comma and add articles before nouns [ci-skip]

(cherry picked from commit d79b7d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants