Refactor compiled_source #46729
Merged
Refactor compiled_source #46729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a continuation of rails#46706 to make sure we don't need to set an instance variable to `@original_source` for the `compile` method to use. We can't call `strict_locals!` after encode so we need to set it to a local variable in `complile`. We changed the `strict_locals!` method to check `NONE` instead of lazily defining instance variables which let us simplify `strict_locals?` to return the value of `strict_locals!`. This simplifies and clarifies the code. Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #46706 to make sure we don't need to set an instance variable to
@original_sourcefor thecompilemethod to use.We can't call
strict_locals!after encode so we need to set it to a local variable incomplile. We changed thestrict_locals!method to checkNONEinstead of lazily defining instance variables which let us simplifystrict_locals?to return the value ofstrict_locals!. This simplifies and clarifies the code.Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org