New Feature - good random string generation #469
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two methods to SecureRandom. random_from_set randomly chooses a given number of items from a set, returning an object of the same type. random_unambiguous_code returns an alpha numeric code which does include characters that could be confused with one another.
I had a need for generating a random string that did not include easily mis-identified characters. Did a search for 'rails generate password' to check if rails already had that functionality and was horrified by what people were suggesting.
The two added methods are so trivial I hesitate to submit them, but people seem to have a hard time with this so perhaps they should be included in rails itself?
I'm not really happy with the names, but couldn't come up with anything better. If anyone has better any ideas I'd be glad to rework the patch.
Feel free to drop the pull request if it is indeed judged too trivial.