Ensure Dockerfile installs commonly needed packages #46953
Conversation
* Starts from the ruby:slim base instead of full ruby * Always install what is neede to build native packages * Include libraries for sqlite3, postgresql, and mysql
|
attn: @dhh FYI: a future pull request will explore reducing deployment image size by using multi-stage builds to remove things like build-essentials which are not needed at runtime. For a preview, see https://fly.io/docs/rails/cookbooks/minimal/ Also it seems that this commit picked up a previously uncommitted change - merging two environment variables into one statement prevents the second setting from referencing the value of the first. I caught this in testing, but failed to included it in the prior commit. If this pull request is not merged, I'll submit a separate PR. buildkite activerecord failures appear to be unrelated to the changes in this PR. |
|
Lovely work, Sam. Very clear what packages are added for what purpose. Looking forward to see how slim we can go with a separate build step 👍 |
Ref: #46953 None of the Ruby redis client need that package.
Motivation / Background
While libvips is an example of a dependency needed to build a native gem, it is not an exhaustive list.
This pull request always includes
build-essentialas installing native gems is common need, not just for applications that include active storage.Detail
Additional information
While this started out simple, it became a minor yak shaving event.
Node also has native modules, and in order to install them you need node-gyp, pkg-config, and python. And the way that python is packaged changed from debian buster to debian bullseye. So heads up: wart warning here, but one that only affects node users, and one that is unlikely to be visible externally as it merely substitutes the name of one python package for another based on the ruby version. See code/comments in app_base.rb for details.
Taking a step back, if we are installing packages, ruby:slim is a better starting point than ruby. It installs a few less packages by default, but also removed docs, man pages, etc. See https://stackoverflow.com/questions/59794891/how-does-debian-differ-from-debian-slim
This pull request explicitly installs libraries for sqlite3, postgresql, mysql, and redis as they are common requirements and don't take up much space.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]A changelog entry is not needed for this change.