Fix flaky test in railties/test/applications/rake/dbs_test.rb
#46965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
changed the title
railties/test/applications/rake/dbs_test.rbrailties/test/applications/rake/dbs_test.rb
zzak
pushed a commit
to zzak/rails
that referenced
this pull request
Jul 3, 2023
Fix flaky test in `railties/test/applications/rake/dbs_test.rb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few recent CI failure examples:
https://buildkite.com/rails/rails/builds/92430#0185a069-e978-438d-b5d7-368e93a838cf
https://buildkite.com/rails/rails/builds/92444#0185a1ab-be07-4b8b-8709-1d0a822eba06
https://buildkite.com/rails/rails/builds/92401#01859d70-4586-4c31-b0bf-8792fbc0196b
To reproduce:
The problem with
use_postgresqlis goodly described in the PR description - #45178.I apologize, I am the one who introduced this flaky test in #46939 馃槃
So I updated
use_postgresqlsignature to not allow custom db names to avoid such mistake in the future.cc @eileencodes