Fix regression from Rails 3.1 #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Rails 3.1, you were allowed to pass a hash to a find_or_create method with multiple attribute names, but this was broken as the arguments were being improperly validated.
|
/cc @jonleighton |
|
@josevalim bro I am cc'd in the OP ;) |
|
My bad. /cc @jonleighton |
jonleighton
added a commit
that referenced
this pull request
Jan 27, 2012
Fix regression from Rails 3.1
jonleighton
added a commit
that referenced
this pull request
Jan 27, 2012
Fix regression from Rails 3.1
|
@josevalim I have merged this /cc @josevalim |
|
@josevalim also for 3-2-stable cc @josevalim |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Rails 3.1, you were allowed to pass a hash to a find_or_create
method with multiple attribute names, but this was broken as the
arguments were being improperly validated.
@jonleighton As per #4660,
match.is_a?(DynamicFinderMatch)is required as it is onlyfind_or_(create|initialize)_bythat accepts a hash.scoped_byrequires arguments to be passed individually.