Allow destroying active storage variants #47150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, forgot about the CHANGELOG, will do. |
shouichi
changed the title
shouichi
force-pushed
the
destroy-variant
branch
2 times, most recently
from
76a63a9
to
2e7959a
Compare
|
@zzak Added a changelog. Could you take a look? |
hahmed
approved these changes
Feb 8, 2023
Background: When creating active storage variants, `ActiveStorage::VariantRecord` is inserted, then a file is uploaded. Because upload can be failed, the file can be missing even though `ActiveStorage::VariantRecord` exists. When a file is missing, we need to delete the corresponding `ActiveStorage::VariantRecord` but there's no API to delete just one variant e.g., `blob.variant(resize_to_limit: [100, 100]).destroy`. Co-authored-by: Yuichiro NAKAGAWA <ii.hsif.drows@gmail.com> Co-authored-by: Ryohei UEDA <ueda@anipos.co.jp>
shouichi
force-pushed
the
destroy-variant
branch
from
2e7959a
to
98abeea
Compare
zzak
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
When creating active storage variants,
ActiveStorage::VariantRecordis inserted, then a file is uploaded. Because upload can be failed, the file can be missing even thoughActiveStorage::VariantRecordexists.When a file is missing, we need to delete the corresponding
ActiveStorage::VariantRecordbut there's no API to delete just one variant e.g.,attachable.variant(resize_to_limit: [100, 100]).destroy.