Don't double-encode nested field_id and field_name index
#47436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
action-view-nested-field-name-calls
branch
from
080cf5f
to
d24ac24
Compare
3 tasks
|
👋 is this PR missing anything to be merged? Would love to have this included in a future update so that I can get ride of a workaround. #45483 (comment) |
|
@seanpdoyle This looks good. Thank you for the fix! Could you update CHANGELOG? |
Closes rails#45483 Closes rails#45523 To quote rails#45483: > `field_name` is adding an extra index parameter, the extra `[0]` in > `parent[children_attributes][0][0][grandchildren_attributes][]` To resolve that issue, this commit reads its default `field_id` and `field_name` method's `index:` option directly from the `@options`. Prior to this commit, that value was read from the `@index` instance variable.
seanpdoyle
force-pushed
the
action-view-nested-field-name-calls
branch
from
d24ac24
to
5cb8678
Compare
|
@amatsuda thank you for the review. I've rebased, added a CHANGELOG entry, and re-pushed. |
|
@seanpdoyle Thank you! |
|
Thanks for following up! |
|
@seanpdoyle Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #45483
Closes #45523
To quote #45483:
Detail
To resolve that issue, this commit reads its default
field_idandfield_namemethod'sindex:option directly from the@options. Prior to this commit, that value was read from the@indexinstance variable.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]