Test and fix for issue 4718 #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @jonleighton |
tenderlove
added a commit
that referenced
this pull request
Jan 31, 2012
Test and fix for issue 4718
|
This broke the build with identity map turned on. Can you please fix the tests and resend? Thanks. |
|
Sorry about that, my bad. test_instantiation_doesnt_try_to_require_corresponding_file(InheritanceComputeTypeTest) [../inheritance_test.rb:267]: I am looking into it. |
|
I submitted #4833 as a fix for the failing tests in active_record |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case and a fix for issue 4718 (#4718).
The problem lied in line 321 of activerecord/lib/relation/finder_methods.rb:
where_values are not blank in case of subclasses but contained the subclass restriction.
Checking for it should resolve the issue.