Disable Joins UUID support #47476
Merged
Disable Joins UUID support #47476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
requested changes
Feb 23, 2023
sj26
force-pushed
the
disable-joins-uuids
branch
from
f65f3f6
to
c30331c
Compare
eileencodes
reviewed
Feb 24, 2023
activerecord/lib/active_record/disable_joins_association_relation.rb
Outdated
Show resolved
Hide resolved
Not all ids are integers. Existing tests still pass without the cast, and removing the cast causes uuid joins to work.
sj26
force-pushed
the
disable-joins-uuids
branch
from
c30331c
to
18ecbe9
Compare
eileencodes
approved these changes
Feb 27, 2023
eileencodes
added a commit
that referenced
this pull request
Feb 27, 2023
Disable Joins UUID support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
We're using
disable_joinsvery successfully — thank you! — but discovered a bug when using non-integer primary keys. Some combinations of non-integer primary keys, has many through associations and order clauses invokes a disable-joins specific association cache which returns nil records. I discovered it's due to a rogue#to_i.This PR uses the attribute type to cast values when reaching into the cache instead of presuming ids are always integers and causes appropriate records to be returned. Existing tests continue to pass.
I've added a test which demonstrates the issue, but it's pretty heavy and I'm not sure is the most appropriate place. Please advise if this test belongs somewhere else.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature.Minor bug fixes and documentation changes should not be included.