Quote binary strings in Arel

[olefriis]

Motivation / Background

When binding binary strings in Arel, we want the data to be properly quoted, otherwise we will generate e.g. MySQL warnings.

Detail

When quoting strings, we now check if they are binary-encoded, and if so, we quote them using the native binary representation.

Co-authored with @matthewd.

Additional information

There is a bit of duplication in the quotation logic between adapters and Type::Binary::Data. Ideas for reducing this without causing additional coupling will be appreciated!

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[zzak]

Tests are failing, can you take a look? 🙇

Error:
--
  | BinaryTest#test_raises_warnings_when_behaviour_raise:
  | Encoding::UndefinedConversionError: "\xEE" from ASCII-8BIT to UTF-8
  | /rails/activerecord/lib/active_record/connection_adapters/sqlite3/quoting.rb:71:in `encode'
  | /rails/activerecord/lib/active_record/connection_adapters/sqlite3/quoting.rb:71:in `type_cast'
  | /rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:244:in `block in type_casted_binds'
  | /rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:240:in `map'
  | /rails/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb:240:in `type_casted_binds'
  | /rails/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb:43:in `exec_query'
  | /rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:142:in `exec_insert'
  | /rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:177:in `insert'
  | /rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:22:in `insert'
  | /rails/activerecord/test/cases/binary_test.rb:47:in `test_raises_warnings_when_behaviour_raise'

[olefriis]

@zzak Yes, sorry, I should have posted earlier on this PR that we found out about that after creating the PR. Sorry about that. We'll definitely look into fixing this!

I've changed the status of the PR to draft while we're working out the kinks so it doesn't get merged by error.

[zzak]

@olefriis You also don't need to use Draft PR, we will know when the PR is ready for review when the build is green and you've squashed your commits. Someone may review it at any time though! [ref]

[olefriis]

@zzak the PR is now in a proper shape for review!

[byroot]

Just a minor nitpick, but LGTM.