Fix Rubocop Offenses

[JuanVqz]

Motivation / Background

This Pull Request has been created because I saw some Rubocop offenses

Detail

This Pull Request fixes some Rubocop offenses.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[yahonda]

Rails 6.1.Z only supports security issues as explained in the Maintenance Policy for Ruby on Rails

Let me close this pull request because addressing RuboCop offenses are not security issues.

[eileencodes]

Merged this so we can have a green 6-1-stable for when PRs are opened to fix security releases #47667

Thank you @JuanVqz!

[JuanVqz]

Merged this so we can have a green 6-1-stable for when PRs are opened to fix security releases #47667

Thank you @JuanVqz!

Hey @eileencodes yes, making it green was the main reason for this, now I noticed there is a new failing cop, already looked at it, it seems like we should just remove that line because is not used, could you please confirm it? then I can open a pr solving it if you agree, thanks!

The line to remove https://github.com/rails/rails/blob/6-1-stable/tasks/release.rb#L113
On the other hand in the main branch, we have this block https://github.com/rails/rails/blob/main/tasks/release.rb#L120-L130 which makes me think about how should we proceed on it.

[eileencodes]

Actually I think the correct change is to backport this #45484 to 7-0-stable and 6-1-stable. Do you want to do that?

[JuanVqz]

Actually I think the correct change is to backport this #45484 to 7-0-stable and 6-1-stable. Do you want to do that?

Sure thing! On it, thanks!