Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting notice receiver on PG connection when ignoring SQL warnings #47518

Merged
merged 1 commit into from Feb 27, 2023
Merged

Avoid setting notice receiver on PG connection when ignoring SQL warnings #47518

merged 1 commit into from Feb 27, 2023

Conversation

adrianna-chang-shopify
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify commented Feb 27, 2023 •
edited by byroot

Motivation / Background

See #46690 (comment).

We should avoid setting the notice processor on the Postgres connection if SQL warnings are ignored.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

cc @yogeshjain999 @byroot

yogeshjain999
yogeshjain999 reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@yogeshjain999 yogeshjain999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick action!!

@byroot
Copy link
Member

byroot commented Feb 27, 2023

Thanks, I'll merge on green.

@adrianna-chang-shopify
Copy link
Contributor Author

Ack, sorry will need to tweak the tests

@byroot byroot merged commit c15093c into rails:main Feb 27, 2023
@fatkodima fatkodima mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshjain999 yogeshjain999 yogeshjain999 left review comments

@byroot byroot byroot approved these changes

Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianna-chang-shopify @byroot @yogeshjain999