Introduce #deliver_enqueued_emails method to ActionMailer::TestHelper #47520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you write tests for this new helper? |
|
Ah sorry I missed that we have test helper tests. Yes I will add them. |
andrewn617
force-pushed
the
introduce-deliver-enqueued-emails-helper-method
branch
3 times, most recently
from
5d2c19f
to
a43ceab
Compare
andrewn617
commented
Feb 28, 2023
| end | ||
| end | ||
|
|
||
| assert_emails(1) |
There was a problem hiding this comment.
If you pass it a block, assert_emails delivers emails enqueued by the block. So to properly test this it needs to be called without a block.
|
@rafaelfranca This is ready for another look. |
…ethod delivers all enqueued email jobs.
Example:
```ruby
def test_deliver_enqueued_emails
deliver_enqueued_emails do
ContactMailer.welcome.deliver_later
end
assert_emails 1
end
```
andrewn617
force-pushed
the
introduce-deliver-enqueued-emails-helper-method
branch
from
a43ceab
to
f2cacd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because we have a
deliver_enqueued_emailstest helper method in the app I work on. I believe this method belongs within Rails and could be useful to anyone using the framework.Detail
ActionMailer::TestHelperhas anassert_enqueued_emailsmethod, which just callsassert_enqueued_jobswith anonlyfilter for mailer delivery jobs. By analogy, this PR introduces adeliver_enqueued_emailsmethod, which callsperform_enqueued_jobswith a filter for delivery jobs.Additional information
N/A
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]