Allow composite primary key to be derived from schema #47633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
reviewed
Mar 13, 2023
nvasilevski
force-pushed
the
allow-deriving-composite-primary-key-from-schema
branch
3 times, most recently
from
f2a9767
to
5931c13
Compare
This commit stops issuing the "Active Record does not support composite primary key" warning and allows `ActiveRecord::Base#primary_key` to be derived as an `Array`
nvasilevski
force-pushed
the
allow-deriving-composite-primary-key-from-schema
branch
from
5931c13
to
257f012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops issuing the
"Active Record does not support composite primary key" warning and allows
ActiveRecord::Base#primary_keyto be derived as anArrayI've removed tests that were expecting or not expecting the warning to be raised as the warning doesn't exist anymore.