Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct variable name in JS example #47716

Conversation

MiguelArgentina
Copy link

Motivation / Background

This Pull Request has been created because an example of Working with JavaScript in Rails uses a variable name that, in my opinion, is not the one available in the scope where it is being used.

Detail

This Pull Request changes the name of the variable in line 47 of the file rails/guides/source/working_with_javascript_in_rails.md

Additional information

N/A

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Mar 20, 2023
@jonathanhefner jonathanhefner merged commit bc2f390 into rails:6-1-stable Mar 20, 2023
@jonathanhefner
Copy link
Member

I can merge this fix, but it will not show up at https://guides.rubyonrails.org/v6.1/working_with_javascript_in_rails.html until a 6.1.8 release is made. And it is unlikely that 6.1.8 will ever be released because the 6.1 series is only receiving security patches, per our maintenance policy. In other words, any future 6.1 releases will probably be 6.1.7.x, not 6.1.x.

Still, thank you for the pull request, @MiguelArgentina! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants