Accept composite primary key in id=
#47720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This is part of the ongoing effort to support composite primary keys.
A high-volume code path (often in tests) is setting a model's primary key using the accessor method. This PR modifies the API of
id=
to accept an array in composite primary key contexts.Implementation
Use branching to either write the value to the single attribute, or values to the list of attributes corresponding to the primary key.
Combining these branches using
Array
removes some handling on when the@primary_key
is nil becauseArray(nil)
resolves to[]
. A test fails in that scenario, so I've opted to use branching.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]