Add support for logging background job enqueue callers #47839
Merged
+108
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
added a commit
to zzak/rails
that referenced
this pull request
Apr 5, 2023
Follow up to rails#47839
3 tasks
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Follow up to rails#47839
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Follow up to rails#47839
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Follow up to rails#47839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently released a gem (https://github.com/fatkodima/job_enqueue_logger) for logging when background jobs are enqueued (additionally with backtraces). Idea is similar to a familiar SQL query tracing, but for background jobs. Getting such info is useful for debugging and generally understanding whats going on in a large app. There was a warm welcome of such a feature on reddit.
That gem works only with raw background processors, which are not logging any info when the job is enqueued. Fortunately, ActiveJob already logs such an info, but is missing backtraces. I was suggested to implement that upstream, so this PR adds backtraces on top of that.
It looks like this:
cc @byroot (as we discussed this)