Fix Active Job log message to correctly report a job failed to enqueue when the adapter raises an ActiveJob::EnqueueError
#47865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
reviewed
Apr 5, 2023
bensheldon
force-pushed
the
enqueue-error-message
branch
from
40cdfea
to
7d28355
Compare
bensheldon
changed the title
ActiveJob::EnqueueErrorActiveJob::EnqueueError
|
LGTM it just needs a rebase |
bensheldon
force-pushed
the
enqueue-error-message
branch
from
7d28355
to
5a92880
Compare
bensheldon
force-pushed
the
enqueue-error-message
branch
from
5a92880
to
723be2e
Compare
|
Rebased 🎸 |
…e when the adapter raises an `ActiveJob::EnqueueError`
bensheldon
force-pushed
the
enqueue-error-message
branch
from
723be2e
to
b1b7deb
Compare
|
Thank you 🙏 |
kamipo
added a commit
that referenced
this pull request
Sep 5, 2023
Fix Active Job log message to correctly report a job failed to enqueue when the adapter raises an `ActiveJob::EnqueueError`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
When an Active Job adapter uses the
ActiveJob::EnqueueErrorfeature introduced in #41191, the log message incorrectly reports that the job was successfully enqueued. This fixes that by using the pre-existing failed-to-enqueue message whenjob.enqueue_erroris present.It would be really nice if this was backported as a bugfix to Rails 7.0, but I understand if the log message being incorrect is pretty minor.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]