Fix associations associated with a CPK model by id attribute #47923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a model associated with a composite primary key by `id` attribute, for example: ```ruby Order.primary_key = [:shop_id, :id] OrderAgreement.primary_key = :id Order.has_many :order_agreements, primary_key: :id ``` Accessing the association should perform queries using the `id` attribute value and not the `id` as Order's composite primary key. ```ruby order = Order.last # => #<Order id: 1, shop_id: 2> order.order_agreements.to_a ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a model associated with a composite primary key by
idattribute, for example:Accessing the association should perform queries using the
idattribute value and not theidas Order's composite primary key.Implementation details
Instead of using public readers to access the values we should use private
_read_attributeto avoid logic treating"id"term as "an identifier" returning the whole composite primary key values tuple instead of theidcolumn value