Update docs about SSE streaming response #47933
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
added a commit
that referenced
this pull request
Apr 16, 2023
Follow-up to #47933. RDoc does not support backticks the way that Markdown does. Instead, inline code must be wrapped with `+` or `<tt>`.
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Follow-up to rails#47933. RDoc does not support backticks the way that Markdown does. Instead, inline code must be wrapped with `+` or `<tt>`.
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Follow-up to rails#47933. RDoc does not support backticks the way that Markdown does. Instead, inline code must be wrapped with `+` or `<tt>`.
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Follow-up to rails#47933. RDoc does not support backticks the way that Markdown does. Instead, inline code must be wrapped with `+` or `<tt>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created to improve the documentation related to
ActionController::Livein Rails.Based on the findings from rack/rack#1619 and #38466, it has been identified that streaming responses do not work with Rack 2.2 by default, requiring users to implement workarounds in their applications.
Currently, this issue can be time-consuming for users to diagnose and resolve, at least the workaround should be mentioned in the Rails docs/guides to provide better guidance to users.
Detail
This Pull Request updates the docs to explain the issue and provide workarounds.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]