Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink headings for alternative libs in assets guide [ci-skip] #47987

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Apr 19, 2023

By linking to the libraries from the headings, the anchor links in the sidebar link directly to the library, instead of the library's section. This behaviour is unexpected.
We can link to the library in the section instead.

By linking to the libraries from the headings the anchor links in the
sidebar link directly to the libraries instead of the library's section.
This behaviour is unexpected.
We can link to the libraries in the section instead.
@rails-bot rails-bot bot added the docs label Apr 19, 2023
@p8 p8 assigned zzak Apr 19, 2023
Copy link
Member

@zzak zzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@p8 p8 merged commit a933125 into rails:main Apr 27, 2023
8 checks passed
@p8 p8 deleted the guides/unlink-asset-pipeline-libs branch April 27, 2023 05:23
@p8
Copy link
Member Author

p8 commented Apr 27, 2023

Thanks @zzak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants