Fix name extraction for module queue adapters #47995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, setting a module as queue adapter would result in `queue_adapter_name` being `"module"`. This PR fixes the name extraction logic to handle module or class queue adapters.
Mangara
commented
Apr 20, 2023
| @@ -43,7 +43,8 @@ def queue_adapter=(name_or_adapter) | |||
| assign_adapter(name_or_adapter.to_s, queue_adapter) | |||
| else | |||
| if queue_adapter?(name_or_adapter) | |||
| adapter_name = "#{name_or_adapter.class.name.demodulize.remove('Adapter').underscore}" | |||
| adapter_class = name_or_adapter.is_a?(Module) ? name_or_adapter : name_or_adapter.class | |||
There was a problem hiding this comment.
Is there a better way to do this?
4 tasks
Mangara
added a commit
to Mangara/rails
that referenced
this pull request
May 2, 2023
We recently made improvements to the name extraction for `MyJob.queue_adapter_name` (see rails#47995 and rails#48003). I had overlooked that we also extract the queue adapter name in a similar (but not identical) way for log messages, so this change aligns the two.
briu
pushed a commit
to briu/rails
that referenced
this pull request
May 4, 2023
We recently made improvements to the name extraction for `MyJob.queue_adapter_name` (see rails#47995 and rails#48003). I had overlooked that we also extract the queue adapter name in a similar (but not identical) way for log messages, so this change aligns the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Currently, setting a module as queue adapter makes
queue_adapter_namereturn"module", instead of a name derived from the name of the module.Detail
This Pull Request fixes the name extraction logic to also derive a name for module or class queue adapters.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]